Skip to content

[CHEF-20217] Fixing restore error as migration is skipped#8823

Merged
vivekshankar1 merged 1 commit intomainfrom
rt/restore_error_as_migration_skipped
Apr 1, 2025
Merged

[CHEF-20217] Fixing restore error as migration is skipped#8823
vivekshankar1 merged 1 commit intomainfrom
rt/restore_error_as_migration_skipped

Conversation

@rensycthomas
Copy link
Copy Markdown
Collaborator

@rensycthomas rensycthomas commented Mar 20, 2025

🔩 Description: What code changed, and why?

Fixing restore issue as migration is skipped.
https://progresssoftware.atlassian.net/browse/CHEF-20217

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

RestoreFailureAsMigrationIsSkipped.docx

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 20, 2025

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit b4f54dd
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/67e672f5219dab0007edfeba
😎 Deploy Preview https://deploy-preview-8823--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread components/automate-cli/cmd/chef-automate/backup.go Outdated
Comment thread components/automate-cli/cmd/chef-automate/backup.go Outdated
Comment thread components/automate-cli/cmd/chef-automate/backup.go Outdated
Copy link
Copy Markdown
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check that os.Exit(1) in backup.go, it should be Exit(0) instead if there is no error

@rensycthomas rensycthomas force-pushed the rt/restore_error_as_migration_skipped branch from e517e65 to a8df56d Compare March 27, 2025 12:14
@rensycthomas rensycthomas changed the title Fixing restore error as migration is skipped [CHEF-20217] Fixing restore error as migration is skipped Mar 27, 2025
@rensycthomas rensycthomas marked this pull request as ready for review March 27, 2025 12:17
@sonarqube-for-infrastructure-prod
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@rensycthomas
Copy link
Copy Markdown
Collaborator Author

please check that os.Exit(1) in backup.go, it should be Exit(0) instead if there is no error

Done

@rensycthomas rensycthomas force-pushed the rt/restore_error_as_migration_skipped branch from fc646b2 to eaf6167 Compare March 28, 2025 05:56
Signed-off-by: Rensy Thomas <rensy.cinuthomas@progress.com>
@rensycthomas rensycthomas force-pushed the rt/restore_error_as_migration_skipped branch from eaf6167 to b4f54dd Compare March 28, 2025 09:59
@vivekshankar1 vivekshankar1 merged commit 18e9304 into main Apr 1, 2025
9 of 12 checks passed
@vivekshankar1 vivekshankar1 deleted the rt/restore_error_as_migration_skipped branch April 1, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants